From 15c153c56a5894b505a1866fca287337fd8313c7 Mon Sep 17 00:00:00 2001
From: droideparanoico <david.alvarez.81@gmail.com>
Date: Thu, 2 Jul 2026 16:44:51 +0200
Subject: [PATCH] Fix feed order (DESC) and cover art in RSS

- Change feed SQL ORDER BY to DESC (newest releases first)
- Remove broken img tag from RSS description (JS onerror not supported in RSS readers)
- Replace with link to Cover Art Archive
---
 src/main/java/com/discdrop/db/DatabaseService.java  | 2 +-
 src/main/java/com/discdrop/util/RSSFeedBuilder.java | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/com/discdrop/db/DatabaseService.java b/src/main/java/com/discdrop/db/DatabaseService.java
index 9247ce8..de0f6e1 100644
--- a/src/main/java/com/discdrop/db/DatabaseService.java
+++ b/src/main/java/com/discdrop/db/DatabaseService.java
@@ -221,7 +221,7 @@ public class DatabaseService {
             var typePlaceholders = String.join(",", primaryTypes.stream().map(t -> "?").toList());
             sql += " AND primary_type IN (" + typePlaceholders + ")";
         }
-        sql += " ORDER BY first_release_date ASC";
+        sql += " ORDER BY first_release_date DESC";
 
         try (Connection conn = getConnection();
              PreparedStatement ps = conn.prepareStatement(sql)) {
diff --git a/src/main/java/com/discdrop/util/RSSFeedBuilder.java b/src/main/java/com/discdrop/util/RSSFeedBuilder.java
index 44ba168..d38fadf 100644
--- a/src/main/java/com/discdrop/util/RSSFeedBuilder.java
+++ b/src/main/java/com/discdrop/util/RSSFeedBuilder.java
@@ -79,8 +79,6 @@ public class RSSFeedBuilder {
 
     private String buildDescription(ReleaseGroup rg) {
         var sb = new StringBuilder();
-        sb.append("<img src=\"https://coverartarchive.org/release-group/")
-          .append(rg.mbid()).append("/front\" alt=\"Cover\" onerror=\"this.style.display='none'\">");
         sb.append("<p><b>").append(escHtml(rg.artistName())).append("</b>")
           .append(" <i>").append(escHtml(rg.title())).append("</i><br>");
         sb.append("Type: ").append(escHtml(rg.primaryType()));
@@ -88,6 +86,8 @@ public class RSSFeedBuilder {
             sb.append(" | Secondary: ").append(escHtml(rg.secondaryTypes()));
         }
         sb.append("<br>First Release Date: ").append(rg.firstReleaseDate());
+        sb.append("<br><a href=\"https://coverartarchive.org/release-group/")
+          .append(rg.mbid()).append("/front\">Cover Art</a>");
         sb.append("</p>");
         return sb.toString();
     }